bito-code-review[bot] commented on code in PR #43863:
URL: https://github.com/apache/superset/pull/43863#discussion_r4093431992
##########
superset/translations/sr_Latn/LC_MESSAGES/messages.po:
##########
@@ -13343,6 +13432,13 @@ msgstr ""
"kao vaš vremenski opseg, i koristite \"Prilagođeno\" da podesite "
"prilagođeni opseg za poređenje."
+msgid ""
+"Overlay simple moving averages of the close price (MA5, MA10, MA15, ...)."
+" Type a custom period to add it."
+msgstr ""
+"Preklopite proste pokretne prosekе cene zatvaranja (MA5, MA10, MA15, ...). "
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>CWE-451: Cyrillic Homoglyph In Latin Locale</b></div>
<div id="fix">
Line 13439 contains a Cyrillic 'е' (U+0435) inside the Latin-script word
'prosekе' ('proseci' translation). sr_Latn must be Latin script; the homoglyph
is invisible to reviewers, breaks search/copy of the rendered label, and
signals unreviewed machine translation. Replace it with Latin 'e'.
([CWE-451](https://cwe.mitre.org/data/definitions/451.html))
</div>
</div>
<small><i>Code Review Run #457542</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/ta/LC_MESSAGES/messages.po:
##########
@@ -9916,6 +9986,13 @@ msgstr "இலக்கு நோட்களின் பெயர்"
msgid "Name of your tag"
msgstr "உங்கள் குறிச்சொல்லின் பெயர்"
+msgid ""
+"Name used for the candlestick series in the legend and tooltip when no "
+"series dimension is set."
+msgstr ""
+"தொடர் பரிமாணம் அமைக்கப்படாதபோது புராணத்திலும் உதவிக்குறிப்பிலும் பயன்படும் "
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>CWE-1007: Legend Mistranslated As Mythology</b></div>
<div id="fix">
The `legend` in "Name used for the candlestick series in the legend and
tooltip..." is translated as "புராணத்திலும்" (mythology). Elsewhere this file
consistently renders legend as "விளக்கக் குறிப்பிலும்" (e.g. "Additional
padding for legend.", "Show legend" entries), and "புராண" occurs nowhere else.
This is a wrong-word mistranslation users will see in the chart legend/tooltip.
([CWE-1007](https://cwe.mitre.org/data/definitions/1007.html))
</div>
</div>
<small><i>Code Review Run #457542</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/ca/LC_MESSAGES/messages.po:
##########
@@ -9393,6 +9446,12 @@ msgstr "Línia d'Etiqueta"
msgid "Label threshold"
msgstr "Llindar d'etiqueta"
+msgid "Label used for decreasing candles in the tooltip."
+msgstr "Etiqueta de les veles baixistes al consell emergent."
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Tooltip term inconsistency</b></div>
<div id="fix">
This entry translates 'tooltip' as 'consell emergent', but the file's
established convention keeps 'tooltip' untranslated (10 msgstrs, e.g. 'Si
mostrar el valor total al tooltip'). This diff introduces all 3 'consell
emergent' occurrences. Use 'tooltip' here for terminology consistency.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
msgstr "Etiqueta de les veles baixistes al tooltip."
````
</div>
</details>
</div>
<small><i>Code Review Run #457542</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/ca/LC_MESSAGES/messages.po:
##########
@@ -11536,6 +11626,13 @@ msgstr ""
"mateixa longitud que el teu rang de temps i usa \"Personalitzat\" per "
"establir un rang de comparació personalitzat."
+msgid ""
+"Overlay simple moving averages of the close price (MA5, MA10, MA15, ...)."
+" Type a custom period to add it."
+msgstr ""
+"Superposa mitjanes mòbils simples del preu de tancament (MA5, MA10, MA15, "
+"...). Escriviu un període personalitzat per afegir-lo."
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Formal register inconsistency</b></div>
<div id="fix">
This entry uses the formal-plural imperative 'Escriviu', but the file's
dominant register is informal singular (117 informal hits like 'el teu rang de
temps' at line 11626 in the adjacent entry vs 6 formal-plural verbs). Use
'Escriu' for register consistency.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
"...). Escriu un període personalitzat per afegir-lo."
````
</div>
</details>
</div>
<small><i>Code Review Run #457542</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/cs/LC_MESSAGES/messages.po:
##########
@@ -9043,6 +9095,12 @@ msgstr "Jednotka velikosti popisku"
msgid "Label threshold"
msgstr "Prahová hodnota popisku"
+msgid "Label used for decreasing candles in the tooltip."
+msgstr "Popisek klesajících svíček v popisku."
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Label/tooltip word collision</b></div>
<div id="fix">
"Popisek klesajících svíček v popisku." uses "popisku" for tooltip while
"Popisek" in the same sentence means label, so the string reads as "label ...
in the label". The catalog renders tooltip as "tooltipu" elsewhere (e.g. line
4333 "Sloupce k zobrazení v tooltipu."). Use "v tooltipu" to remove the
collision.
</div>
</div>
<small><i>Code Review Run #457542</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/zh_TW/LC_MESSAGES/messages.po:
##########
@@ -1046,6 +1046,12 @@ msgid ""
" bars that extend left and right from a central axis."
msgstr ""
+msgid ""
+"A candlestick chart shows opening, closing, high, and low values for each"
+" period. It is commonly used for financial and other time-series range "
+"analysis."
+msgstr "K線圖顯示每個週期的開盤、收盤、最高和最低值。常用於金融及其他時間序列區間分析。"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>K線 term spacing inconsistent</b></div>
<div id="fix">
The same candlestick term is written two ways in this diff: "K線" (lines
1053, 3434, 3437, 3442) vs "K 線" (9817, 9820, 11181, 12020) — file-wide grep
counts 4 vs 4 occurrences, all introduced here. Users will see inconsistent
labels for one concept; line 20399 adds a third register (陽線/陰線 vs 上漲/下跌 K 線).
Pick one form (suggest "K線", matching the chart names) and apply it to all
candlestick strings.
</div>
</div>
<small><i>Code Review Run #457542</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/ca/LC_MESSAGES/messages.po:
##########
@@ -9393,6 +9446,12 @@ msgstr "Línia d'Etiqueta"
msgid "Label threshold"
msgstr "Llindar d'etiqueta"
+msgid "Label used for decreasing candles in the tooltip."
+msgstr "Etiqueta de les veles baixistes al consell emergent."
+
+msgid "Label used for increasing candles in the tooltip."
+msgstr "Etiqueta de les veles alcistes al consell emergent."
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Tooltip term inconsistency</b></div>
<div id="fix">
Same terminology inconsistency as line 9450: 'consell emergent' vs the
established 'tooltip' convention (10 msgstrs). This is the second of three
instances introduced by this diff. Use 'tooltip' for consistency.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
msgstr "Etiqueta de les veles alcistes al tooltip."
````
</div>
</details>
</div>
<small><i>Code Review Run #457542</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/ca/LC_MESSAGES/messages.po:
##########
@@ -10634,6 +10702,13 @@ msgstr "Nom dels nodes destí"
msgid "Name of your tag"
msgstr "Nom de la teva etiqueta"
+msgid ""
+"Name used for the candlestick series in the legend and tooltip when no "
+"series dimension is set."
+msgstr ""
+"Nom de la sèrie de candlestick a la llegenda i al consell emergent quan no "
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Tooltip term inconsistency</b></div>
<div id="fix">
Third instance of 'consell emergent' vs the established 'tooltip' convention
(10 msgstrs). This entry describes the legend and tooltip together; using
divergent terms for 'tooltip' here compounds the inconsistency from lines
9450/9453.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
"Nom de la sèrie de candlestick a la llegenda i al tooltip quan no "
````
</div>
</details>
</div>
<small><i>Code Review Run #457542</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/ca/LC_MESSAGES/messages.po:
##########
@@ -19577,6 +19693,15 @@ msgstr ""
"Quan està marcat, el mapa farà zoom a les teves dades després de cada "
"consulta"
+msgid ""
+"When enabled, increasing candles use the increase color and decreasing "
+"candles use the decrease color. Turn off to use one series color, with a "
+"filled body for increases and a hollow body for decreases."
+msgstr ""
+"Si està activat, les veles alcistes usen el color de pujada i les "
+"baixistes el de baixada. Desactiveu-ho per usar un sol color de sèrie, amb "
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Color label terminology mismatch</b></div>
<div id="fix">
'color de pujada'/'color de baixada' don't match the established control
labels 'Increase color'→'Augment' (line 8941) and 'Decrease color'→'Disminuir'
(line 5763) that this text references. Also 'Desactiveu-ho' is formal plural vs
the file's informal register. Align both.
</div>
<details>
<summary>
<b>Code suggestion</b>
</summary>
<blockquote>Check the AI-generated fix before applying</blockquote>
<div id="code">
````suggestion
"Si està activat, les veles alcistes usen el color d'augment i les "
"baixistes el de disminució. Desactiva-ho per usar un sol color de sèrie,
amb "
````
</div>
</details>
</div>
<small><i>Code Review Run #457542</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/cs/LC_MESSAGES/messages.po:
##########
@@ -9043,6 +9095,12 @@ msgstr "Jednotka velikosti popisku"
msgid "Label threshold"
msgstr "Prahová hodnota popisku"
+msgid "Label used for decreasing candles in the tooltip."
+msgstr "Popisek klesajících svíček v popisku."
+
+msgid "Label used for increasing candles in the tooltip."
+msgstr "Popisek rostoucích svíček v popisku."
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Label/tooltip word collision</b></div>
<div id="fix">
Same collision as line 9099: "Popisek rostoucích svíček v popisku." uses
"popisku" for tooltip while "Popisek" means label, and the catalog elsewhere
renders tooltip as "tooltipu" (line 4333). Use "v tooltipu" for consistency and
clarity.
</div>
</div>
<small><i>Code Review Run #457542</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
##########
superset/translations/cs/LC_MESSAGES/messages.po:
##########
@@ -13848,10 +13945,16 @@ msgstr "Nastavení zvýšení série"
msgid "Series limit"
msgstr "Limit sérií"
+msgid "Series name"
+msgstr "Název řady"
+
#, fuzzy
msgid "Series settings"
msgstr "Nastavení sérií"
+msgid "Series style"
+msgstr "Styl řady"
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Inconsistent series term</b></div>
<div id="fix">
"Series style" is translated "Styl řady" while sibling msgid `Series Style`
(line 13931) is "Styl série"; the new `Series colors` (13937) and `Series name`
(13949) likewise use "řad/řady" against 11 sibling `Series*` entries that use
"série" (grep: 51 "séri" lines vs 17 "řad" tokens, most of the latter being the
fixed phrase "časových řad"). The same control family will render both terms.
Align the three new strings on "série".
</div>
</div>
<small><i>Code Review Run #457542</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
