bito-code-review[bot] commented on PR #44613:
URL: https://github.com/apache/superset/pull/44613#issuecomment-5821709229
<!-- Bito Reply -->
The flagged issue is correct. The pull request already implements a
resolution for this by introducing the `DASHBOARD_SAVE_SUCCEEDED` action and
dispatching it within `saveChartConfiguration` (in
`superset-frontend/src/dashboard/actions/chartCustomizationActions.ts`) and
`PropertiesModal` (in
`superset-frontend/src/dashboard/components/PropertiesModal/index.tsx`). The
reducers for `dashboardInfo` and `dashboardState` have also been updated to
handle this action and increment `versionHistoryRevision`, which triggers the
necessary refresh in the version history timeline. No further implementation is
required to resolve the flagged issue.
**superset-frontend/src/dashboard/actions/chartCustomizationActions.ts**
```
dispatch(dashboardSaveSucceeded(id));
const currentMetadata = getState().dashboardInfo.metadata;
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
