mikebridge commented on PR #44613: URL: https://github.com/apache/superset/pull/44613#issuecomment-5823412338
Good catch, Richard. I added the success-only `dashboardSaveSucceeded(id)` dispatch after `saveChartConfiguration` completes, so a successful cross-filter scoping save advances the Version History refresh signal; the failure path does not. A red/green regression covers both outcomes, 26 focused tests and branch-file pre-commit pass, and the focused React/Clean Code review found no issues. The change is on the fork branch at mikebridge/superset@459191eed3057f8f51725ec8f4f7f3e9a3ee8ba3. GitHub is still showing the prior PR head at the time of this comment, so exact-head CI is pending PR synchronization. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
