codeant-ai-for-open-source[bot] commented on code in PR #44681:
URL: https://github.com/apache/superset/pull/44681#discussion_r4112661129
##########
superset/mcp_service/chart/tool/list_charts.py:
##########
@@ -63,6 +63,52 @@
_DEFAULT_LIST_CHARTS_REQUEST = ListChartsRequest()
+# Relationships that resolve a chart's live datasource. ``datasource_name`` is
+# read through them rather than from the stored ``Slice.datasource_name``
+# column, which can be stale after a dataset rename or a chart re-point.
+_LIVE_DATASOURCE_RELATIONSHIPS = ("table", "semantic_view")
+
+
+class _ChartListCore(ModelListCore[ChartList]):
+ """List core that loads the live datasource whenever its name is requested.
+
+ Requesting only plain columns makes the DAO return row tuples, which cannot
+ reach the ``table`` / ``semantic_view`` relationships. Adding them to the
+ DAO load list switches it to full model instances with the relationships
+ eager-loaded, so the live name costs no per-chart query.
+ """
+
+ def _call_dao_list(
+ self,
+ filters: Any,
+ order_column: str,
+ order_direction: str,
+ page: int,
+ page_size: int,
+ search: str | None,
+ columns_to_load: list[str],
+ custom_filters: dict[str, Any] | None = None,
+ ) -> tuple[list[Any], int]:
+ if "datasource_name" in columns_to_load:
+ columns_to_load = [
+ *columns_to_load,
+ *(
+ rel
+ for rel in _LIVE_DATASOURCE_RELATIONSHIPS
+ if rel not in columns_to_load
+ ),
+ ]
Review Comment:
**Suggestion:** `datasource_name` filters still query the stale
`Slice.datasource_name` column, so current names do not match while old names
can return incorrect charts.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=b74365d83f9c4fc6842f417a2c20d0c5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=b74365d83f9c4fc6842f417a2c20d0c5&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** superset/mcp_service/chart/tool/list_charts.py
**Line:** 92:100
**Comment:**
*Api Mismatch: `datasource_name` filters still query the stale
`Slice.datasource_name` column, so current names do not match while old names
can return incorrect charts.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44681&comment_hash=704c7a4b42a13f72244491140ebc313626e3e383c636b892d5facb1a8dcd2842&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44681&comment_hash=704c7a4b42a13f72244491140ebc313626e3e383c636b892d5facb1a8dcd2842&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
