aminghadersohi commented on PR #44681: URL: https://github.com/apache/superset/pull/44681#issuecomment-5902060688
Addressed the “Naming rule mirrored in SQL” suggestion from Run #e5979c in b4cc6fd8288555a4fc4b7e621be13fa203ecbd76. Added the requested cross-reference to SqlaTable.name beside the SQL expression, plus six parity cases comparing SQL filtering with the Python name and chart serialization for null, empty, and populated schemas, with and without a catalog. This guards against future naming-rule drift without changing the model API. Validation: MCP chart tests: 2,197 passed, 3 skipped; dashboard, privacy, and schema-discovery tests: 666 passed. All applicable branch-scoped pre-commit hooks passed, including mypy. Master was merged in faa83789d0807bf4ba1ab0649b306280aa7e76fc, preserving both documentation sections. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
