aminghadersohi commented on PR #44681: URL: https://github.com/apache/superset/pull/44681#issuecomment-5902783426
Review completed at b4cc6fd8288555a4fc4b7e621be13fa203ecbd76: no actionable findings in the full nine-file diff. Checked live datasource resolution, filtering/counting/pagination, metadata redaction, chart/dataset permission scoping, and test coverage. Merge faa83789 preserves both the asset-catalog and datasource-metadata documentation and the overlapping backend changes. Validation: focused datasource tests **42 passed**; full MCP unit suite **5,717 passed, 3 skipped**; chart permission-filter and Slice-model tests **53 passed**. Pre-commit passed on all nine PR files, including mypy and pylint. Disposition: no fixes required, no commits pushed, nothing left open. Working tree clean; no services started. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
