codeant-ai-for-open-source[bot] commented on code in PR #44722:
URL: https://github.com/apache/superset/pull/44722#discussion_r4113714314
##########
.github/workflows/superset-helm-lint-test.yml:
##########
@@ -43,19 +43,8 @@ jobs:
with:
install-superset: "false"
- # Still vendored (not de-vendored like chart-releaser-action below): the
- # allowlisted helm/[email protected] depends internally on
- # astral-sh/[email protected], which isn't itself on the ASF Actions
- # allowlist (only v8.1.0+ are, at apache/infrastructure-actions'
- # actions.yml). Needs an INFRA request before this can de-vendor too.
- # chart-testing-action is a submodule (not a plain directory), and the
- # $/ self-repository syntax resolves action files directly from the
- # repository without performing a real (submodule-aware) checkout, so
- # it can't see into a submodule's link. Keep this one on the
- # workspace-relative ./ form, consistent with every other workflow in
- # the repo that references a submodule action.
- name: Set up chart-testing
- uses: ./.github/actions/chart-testing-action # zizmor:
ignore[self-repository] - $/ cannot resolve an action that lives in a
submodule; ./ is required here
+ uses:
helm/chart-testing-action@6ec842c01de15ebb84c8627d2744a0c2f2755c9f # v2.8.0
Review Comment:
**Suggestion:** Without `version`, this action uses its bundled default
chart-testing release, which can change `ct` behavior and break the workflow's
existing command and configuration contract.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Api mismatch`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=4ef99324afa945048e4a3e6cd8059c50&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=4ef99324afa945048e4a3e6cd8059c50&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:** .github/workflows/superset-helm-lint-test.yml
**Line:** 47:47
**Comment:**
*Api Mismatch: Without `version`, this action uses its bundled default
chart-testing release, which can change `ct` behavior and break the workflow's
existing command and configuration contract.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44722&comment_hash=d6db3a1681b0fcc3cc9327569433235432fe6d42c02c40d4615e95462ec083f2&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44722&comment_hash=d6db3a1681b0fcc3cc9327569433235432fe6d42c02c40d4615e95462ec083f2&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
