sadpandajoe commented on code in PR #44722: URL: https://github.com/apache/superset/pull/44722#discussion_r4140047739
########## helm/superset/tests/checksum_test.yaml: ########## @@ -23,7 +23,7 @@ templates: - deployment-ws.yaml - deployment-mcp.yaml tests: - - it: main deployment has new config checksums, not the old connections checksum + - it: main deployment has new config checksum, not the old connections checksum Review Comment: This wording-only change makes the Helm workflow treat the chart as modified, but `Chart.yaml` is still at 0.22.8, so `ct lint` now fails its version-bump check before `helm-unittest` runs. Could we remove this validation placeholder now that the workflow has been exercised (or bump the chart version if a chart change is intended)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
