aipiJuancho commented on PR #44531: URL: https://github.com/apache/superset/pull/44531#issuecomment-5852750476
Thanks @rusackas! Rebased onto current master (`b10851d`) — CI should be clear now, as you predicted. Also took you up on the regression test (`ba90c05`): a vertical-bar test in `FilterBar.test.tsx` that runs the exact user flow — Clear all → Apply → re-select the same value — and asserts Apply re-enables. Verified it **fails without the forwarding fix** (28 pass, only this one fails: the Select plugin's local reducer stays pinned and discards the re-selection as a no-op) and passes with it. One incidental fix in the same file: the `filter_range` test's catch-all `chart/data` mock was registered unnamed, and fetch-mock v12 matches routes in declaration order — so it shadowed the mocks of every later test (the horizontal clear-all test was passing partly vacuously as a result). It is now named and removed at the end of that test. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
