codeant-ai-for-open-source[bot] commented on code in PR #44531:
URL: https://github.com/apache/superset/pull/44531#discussion_r4114138250
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx:
##########
@@ -616,6 +620,10 @@ test('Clear All stages filter_range clear with [null,
null], dispatched on Apply
filterState: { value: [null, null], validateStatus: undefined },
extraFormData: {},
});
+ // Scope the catch-all chart/data mock to this test: fetch-mock matches
+ // routes in declaration order, so an unscoped route here would shadow the
+ // mocks declared by the tests that follow.
+ fetchMock.removeRoute('range-clear-chart-data');
Review Comment:
**Suggestion:** Route removal occurs only after the assertions, so any
failed assertion leaves the catch-all route installed and can corrupt
subsequent tests.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Rarely` ยท ๐ท๏ธ `Missing cleanup`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=ac9f5c3fe27d4da9bd0c1cae95e187e0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=ac9f5c3fe27d4da9bd0c1cae95e187e0&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx
**Line:** 626:626
**Comment:**
*Missing Cleanup: Route removal occurs only after the assertions, so
any failed assertion leaves the catch-all route installed and can corrupt
subsequent tests.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44531&comment_hash=76aaa7aa6771c8d77b0725e93825481a7f97f6d7f3fe5b460db053c2bdd2467a&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44531&comment_hash=76aaa7aa6771c8d77b0725e93825481a7f97f6d7f3fe5b460db053c2bdd2467a&reaction=dislike'>๐</a>
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx:
##########
@@ -774,6 +782,115 @@ test('Clear All in horizontal bar does not re-apply
default values', async () =>
updateDataMaskSpy.mockRestore();
});
+test('Clear All in vertical bar lets the same value be re-selected
afterwards', async () => {
+ // Vertical counterpart to the horizontal regression test above (issue
+ // #44530). `Vertical.tsx` used to destructure `clearAllTriggers`/
+ // `onClearAllComplete` without ever forwarding them to `FilterControls`
+ // (they were also missing from the `filterControls` `useMemo` deps), so
+ // filter plugins never received the clear-all trigger and their local
+ // `useImmerReducer` state stayed pinned to the last selection. The
+ // plugin's reducer discards any action whose new state stringifies equal
+ // to that pinned state, so re-selecting the value that Clear All removed
+ // was a silent no-op: Apply never re-enabled. Without the forwarding
+ // this test fails on the last assertion.
+ fetchMock.post(
+ 'glob:*/api/v1/chart/data',
+ {
+ result: [
+ {
+ data: [{ test_column: 'East' }, { test_column: 'West' }],
+ colnames: ['test_column'],
+ coltypes: [1],
+ },
+ ],
+ },
+ { name: 'vertical-clear-chart-data' },
+ );
Review Comment:
**Suggestion:** The catch-all route remains registered after this test
succeeds, so later chart requests can receive the East/West fixture and become
order-dependent.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Often` ยท ๐ท๏ธ `Missing cleanup`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=3f7e54852f9341a0b521f7d827090d77&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=3f7e54852f9341a0b521f7d827090d77&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterBar.test.tsx
**Line:** 796:808
**Comment:**
*Missing Cleanup: The catch-all route remains registered after this
test succeeds, so later chart requests can receive the East/West fixture and
become order-dependent.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44531&comment_hash=c0f74c33d33c5b2dfe58acf0f819adba236a3f7931caac8936aa641604ee1428&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44531&comment_hash=c0f74c33d33c5b2dfe58acf0f819adba236a3f7931caac8936aa641604ee1428&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
