rusackas commented on code in PR #44657:
URL: https://github.com/apache/superset/pull/44657#discussion_r4114347287
##########
superset-frontend/plugins/plugin-chart-pivot-table/src/react-pivottable/utilities.ts:
##########
@@ -408,7 +428,7 @@ const cellValue =
}
},
value() {
- return this.val;
+ return this.mixedMetrics ? null : this.val;
Review Comment:
Traced this through and I don't think it reproduces. `cellValue`'s own
`format` already special-cases null to `''` before the shared formatter ever
sees it, and `fractionOf`'s `value()` explicitly returns `null` before the
division whenever the numerator is null (needed for a different case: a real
DB-computed NULL rollup). Even without either guard, `Number.isFinite(null)` is
`false`, so the shared formatter already blanks it. The exact scenario
(mixed-metric + percent_total) is covered end-to-end by the existing
'TableRenderer blanks the grand-total corner cell...' test, which passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
