rusackas commented on PR #44657: URL: https://github.com/apache/superset/pull/44657#issuecomment-5853430285
You're right, and `_collapsed_metric`'s own docstring is stale now -- it says it mirrors the browser's old last-metric-wins behavior, which this PR just replaced with a blank cell. Backend/export parity for this fix is real scope, separate from the browser change here (and separate from #44625/#44631, which is about a different mixed-up case: non-additive metrics re-aggregating already-aggregated cells). Opened apache/superset#44725 to track it rather than rush a fix into this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
