bito-code-review[bot] commented on PR #44726: URL: https://github.com/apache/superset/pull/44726#issuecomment-5853882198
<!-- Bito Reply --> The flagged issue regarding `strict: false` in `tsconfig.json` is correct. When `strict` is disabled, TypeScript skips critical safety checks like `strictFunctionTypes` and `strictPropertyInitialization`, which can lead to type-unsafe code being accepted. To resolve this, you should enable `strict` mode in your base `tsconfig.json` or explicitly enable the necessary strict flags in the `compilerOptions` of your project configurations. I have checked the PR comments, and there are no other pending review comments to address at this time. Would you like me to proceed with enabling `strict: true` in the base `tsconfig.json`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
