rusackas commented on code in PR #44620:
URL: https://github.com/apache/superset/pull/44620#discussion_r4116909641
##########
superset/mcp_service/chart/chart_helpers.py:
##########
@@ -151,7 +151,7 @@ def find_chart_by_identifier(
{"query_options": query_options} if query_options is not None else {}
)
if isinstance(identifier, int) or (
- isinstance(identifier, str) and identifier.isdigit()
+ isinstance(identifier, str) and identifier.isdecimal()
Review Comment:
Added a regression test for each mcp_service resolver using a non-decimal
digit like `²`, confirming it falls through to the uuid/slug branch instead of
hitting `int()`. Should pin the rest of them now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
