rusackas commented on PR #44620: URL: https://github.com/apache/superset/pull/44620#issuecomment-5859731013
@aminghadersohi `filters.py:169` doesnt actually call `int()` on the digit-filtered ids, it passes them straight into `Dashboard.id.in_(...)`, so its the same no-int()-call shape as `get_chart_preview.py`s heuristic rather than the isdigit-then-int() pattern this PR is fixing. Fair on the count being off though. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
