bito-code-review[bot] commented on code in PR #44620:
URL: https://github.com/apache/superset/pull/44620#discussion_r4118822037
##########
tests/unit_tests/mcp_service/chart/tool/test_update_chart_preview.py:
##########
@@ -1445,6 +1445,37 @@ async def test_dataset_access_denied_short_circuits(
assert error["error_type"] == "DatasetNotAccessible"
mock_create_form_data.assert_not_called()
+ @patch.object(update_chart_preview_module, "_find_dataset")
+ @patch("superset.daos.dataset.DatasetDAO.find_by_id")
+ @pytest.mark.asyncio
+ async def test_non_decimal_digit_dataset_id_uses_uuid_lookup(
+ self,
+ mock_find_by_id,
+ mock_find_dataset,
+ mcp_server,
+ mock_auth,
+ ):
Review Comment:
<div>
<div id="suggestion">
<div id="issue"><b>Missing test type hints</b></div>
<div id="fix">
BITO.md rules 7819 and 13155 mandate explicit return type hints on test
methods (including async tests) and typed fixture parameters. This new async
test declares neither: the signature ends with `):` and the
`mcp_server`/`mock_auth` fixture params are untyped. Add `-> None:` and
annotate the fixture params per the convention.
</div>
</div>
<small><i>Code Review Run #6dd3c2</i></small>
</div>
---
Should Bito avoid suggestions like this for future reviews? (<a
href=https://alpha.bito.ai/home/ai-agents/review-rules>Manage Rules</a>)
- [ ] Yes, avoid them
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
