rusackas commented on PR #44154: URL: https://github.com/apache/superset/pull/44154#issuecomment-5867769533
Also deduped the same repeated string in downloadAsImage.tsx. Not merging SliceHeaderControlsProps into types.ts though: SliceHeader/index.tsx already re-declares `exportPivotExcel` locally with a different (1-arg vs 2-arg) signature, and Chart.tsx papers over the mismatch with an `as unknown as` cast. Merging the interfaces first needs untangling that, which is bigger than this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
