rusackas commented on code in PR #44154:
URL: https://github.com/apache/superset/pull/44154#discussion_r4158950580
##########
superset-frontend/src/dashboard/components/menu/DownloadMenuItems/index.tsx:
##########
@@ -158,7 +165,15 @@ export const useDownloadMenuItems = (
const onDownloadImage = async (e: SyntheticEvent) => {
try {
- downloadAsImage(SCREENSHOT_NODE_SELECTOR, dashboardTitle, true)(e);
+ downloadAsImage(
Review Comment:
@sadpandajoe good call. Added tests that click the dashboard PDF/image items
and the Explore "Export All Data" JPEG item and assert the toast callbacks land
in the right argument slots.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
