drivaspreset commented on code in PR #43004:
URL: https://github.com/apache/superset/pull/43004#discussion_r4123533903


##########
tests/integration_tests/superset_test_config.py:
##########
@@ -156,6 +156,27 @@ def GET_FEATURE_FLAGS_FUNC(ff):  # noqa: N802
 }
 
 
+# Async chart data runs on the Global Task Framework, which reaches Redis 
through
+# the coordination service rather than a GAQ-specific cache backend
+# (`GLOBAL_ASYNC_QUERIES_CACHE_BACKEND` was removed with that migration). The
+# config default is `None`, so without this there is no coordinator: task
+# completion is never signalled, submissions return 202 and the client waits
+# forever. Built from the same environment variables as `CACHE_CONFIG` above,
+# with its own DB index so coordination streams stay out of the query cache.
+#
+# Note the discrete host/port/db keys rather than a CACHE_REDIS_URL: the Redis
+# backends read CACHE_REDIS_HOST/PORT/DB and ignore a URL entirely, so 
supplying
+# one silently leaves the connection on its localhost:6379 defaults.
+COORDINATION_REDIS_DB = os.environ.get("COORDINATION_REDIS_DB", 5)  # noqa: 
F405
+DISTRIBUTED_COORDINATION_CONFIG = {

Review Comment:
   Fixed in c9dcafb8af by moving `DISTRIBUTED_COORDINATION_CONFIG` into a new
   `tests/integration_tests/superset_test_config_gaq.py`, following the existing
   `superset_test_config_thumbnails` / `_sqllab_backend_persist_off` pattern. 
Only
   `playwright-tests-gaq` points at it; `playwright-tests` and `cypress-matrix`
   still use the shared config.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to