drivaspreset commented on PR #43004:
URL: https://github.com/apache/superset/pull/43004#issuecomment-5875523369
Status update after merging master up — all threads addressed and CI is
green.
### Merge with master
#44659 ("collapse Playwright experimental workflow into E2E
playwright-tests")
deleted `.github/workflows/superset-playwright.yml`, which is where the GAQ
job
lived, and removed the `INCLUDE_EXPERIMENTAL` machinery from
`playwright.config.ts` and `bashlib.sh`.
`playwright-tests-gaq` therefore moved into `superset-e2e.yml`. I kept it as
its
own job rather than folding it in as a step of `playwright-tests`, because it
needs a Celery worker and a 60s startup window — putting that on the required
path would let a GAQ flake block unrelated PRs. It stays `continue-on-error`
and outside `playwright-tests-required`, which still gates only on
`playwright-tests`.
### Review fixes (c9dcafb8af)
1. **Did-the-suite-run gate** now counts `expected + unexpected + flaky` as
"executed" instead of `expected` alone, so a run where every test
genuinely
fails reports the real failure rather than blaming an inactive
`GLOBAL_ASYNC_QUERIES`.
2. **Suite selection** is now `--project=chromium-gaq` instead of a
hand-maintained three-file list. `playwright.config.ts`'s `testMatch` —
the
same glob that excludes these specs from the default and sqllab projects —
is now the single definition of what the suite contains, so a new matching
spec can't end up running nowhere.
3. **`DISTRIBUTED_COORDINATION_CONFIG`** moved out of the shared
`superset_test_config` into a new `superset_test_config_gaq`, following
the
existing `_thumbnails` / `_sqllab_backend_persist_off` pattern. It was
leaking a real Redis backend into every unit-test run via `conftest.py`,
because `_init_distributed_coordination` never clears
`_distributed_coordination`. Only the GAQ job points at the new config.
4. **zizmor**: the GAQ job's six `./.github/actions/cached-dependencies` uses
now carry the `# zizmor: ignore[self-repository]` suppression the other
sixteen in the file already had.
### Correction on the change-detector thread
The `playwright` token I added to the frontend pattern is no longer in the
branch. It existed so `superset-playwright.yml` would trigger its own jobs,
and
that file no longer exists — GAQ now lives in `superset-e2e.yml`, which the
pre-existing `e2e` token already matches. I kept `^\.github/actions/` and its
test, since composite actions are still matched by nothing else.
### CI
All checks pass, including both GAQ legs:
Running with no explicit paths (project selection comes from
PLAYWRIGHT_EXTRA_ARGS, if set)
Running 10 tests using 1 worker
GAQ suite: 10 passed, 0 failed, 0 flaky, 0 skipped
`0 flaky` is the meaningful part: this suite previously reached green *via* a
retry after `tag_name_key` / `Chart could not be created`, so that confirms
the
race window is closed rather than simply not hit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
