drivaskbk01 commented on code in PR #43004:
URL: https://github.com/apache/superset/pull/43004#discussion_r4124253982
##########
superset-frontend/playwright.config.ts:
##########
@@ -161,6 +168,25 @@ export default defineConfig({
},
]
: []),
+ // Global Async Queries tests need the GLOBAL_ASYNC_QUERIES feature flag
+ // enabled in the Flask backend, plus Redis and a running Celery worker --
+ // without a worker, submissions return 202 and no job ever executes. The
+ // workflow's GAQ step provisions all three and sets INCLUDE_GAQ, so these
+ // specs never load in the required run, where the pipeline is inert. Same
+ // strict 'true' check as INCLUDE_EMBEDDED.
+ ...(process.env.INCLUDE_GAQ?.toLowerCase() === 'true'
+ ? [
+ {
+ name: 'chromium-gaq',
Review Comment:
Following up with the CI evidence, since the ask was specifically that the
coverage stop masking the flake.
Both GAQ legs are green on the current run and the suite reports no retries
at all:
```
Running 10 tests using 1 worker
GAQ suite: 10 passed, 0 failed, 0 flaky, 0 skipped
```
Previously this suite reached green via `flaky` (a first-attempt
`tag_name_key` / `Chart could not be created`, passing on retry). `0 flaky` is
what confirms the race window is actually closed rather than just not hit.
Worth being explicit that this only stops the suite from hiding the bug — it
does not fix it. `get_tag` in `superset/tags/models.py` is an unguarded
SELECT-then-INSERT against `tag.name`'s unique index, so any two concurrent
chart creations by the same user can still hit it outside this suite. Happy to
open a separate issue for that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
