rusackas commented on PR #44536: URL: https://github.com/apache/superset/pull/44536#issuecomment-5880255946
Rebased onto current master, which had a real conflict beyond the usual pot/lockfile churn: #44742 landed today and dropped the `po2json` npm dependency entirely (replaced with an in-repo `scripts/po2json.js`/`po2json-cli.js` built on `gettext-parser` directly, for unrelated CVE/maintenance reasons). That's not redundant with this PR, it solves a different problem (the *dependency*, not the *shell script*), so `po2json.sh` still needed retiring here for Windows support. But `compile_po.py` was resolving `@hainenber/po2json` as an installed npm package, which #44742 just removed, so it would've broken immediately on merge. Updated `compile_po.py` to invoke `scripts/po2json-cli.js` at its fixed repo path instead of resolving it from `node_modules`, and dropped `--format jed --fuzzy` (the old package's CLI flags, not applicable to the new one, which only takes `--domain <domain> <input> <output>`). `oxfmt` resolution is unchanged. Verified for real, not just the mocked unit tests: ran `python scripts/translations/compile_po.py` end-to-end against all 30 locale files, 0 errors. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
