rusackas commented on PR #39724: URL: https://github.com/apache/superset/pull/39724#issuecomment-5943216481
I'll just close this out, but happy to revisit/reopen if needed. #44742 landed on `master` since this branch last updated and solves the same problem (retiring the vulnerable npm `po2json` package, and the Windows cmd.exe wrapper-escaping issue) a different way, as a JS rewrite on gettext-parser invoked directly via `node`, rather than this Python port. This PR seems moot, and I chased the same idea myself on a follow-up PR (#44536) and ultimately closed it once verifying `po2json.sh` calling `node scripts/po2json-cli.js` directly already bypasses the same `cmd.exe`/`.bat` wrapper class of bug this PR was working around. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
