FrancescoCastaldi commented on PR #39724: URL: https://github.com/apache/superset/pull/39724#issuecomment-5887145792
Hi @rusackas! All the points from your review have been addressed: - **oxfmt**: the script now uses oxfmt (via esolve_node_entry) throughout — no prettier dependency anywhere. The gitignore quirk comment from po2json.sh has been carried over (lines 150-156 in scripts/translations/compile_po.py). - **Unit tests**: added in ests/unit_tests/scripts/translations/compile_po_test.py, following the same pattern as ackfill_po_test.py and uild_translation_index_test.py. - ** ind_node_bin / local-first resolution**: replaced entirely by esolve_node_entry, which reads the package's own package.json in field and runs via ode <entry> directly — no px fallback. Could you take another look when you get a chance? Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
