rusackas commented on PR #44148: URL: https://github.com/apache/superset/pull/44148#issuecomment-5883575254
@aminghadersohi appreciate the continued work here, sha174n's scoped pass looks solid and the bito/codeant threads all got real fixes. But I don't see the `region_format` crash from my last comment addressed yet, in `CountryMap`'s `transformProps.ts` or the `deck_scatter` path in `Scatter/transformProps.ts`. Both still throw on a sparse/non-numeric row instead of blanking it. That's still the one blocking this for me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
