rusackas commented on PR #44718: URL: https://github.com/apache/superset/pull/44718#issuecomment-5883833567
Really solid work on the Doris fixes, the quarter grain, URI scheme and error mapping all look well covered by the new tests. One thing before this merges, though: `require_mysql_tls` here changes SSL toggle behavior for every MySQL connection, not just Doris, and #44723 already carries the exact same fix as its own PR. Should we land that one first and have this branch off it, or is #44723 meant to close in favor of this? Would rather not end up reviewing (and merging) the same security-sensitive change twice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
