aminghadersohi commented on PR #44718: URL: https://github.com/apache/superset/pull/44718#issuecomment-5884240192
Verified both review bodies at 03306ebaf0. Run #473e5d: d14f65bd1a fixes the TLS round-trip and all six requested test docstrings (four Doris, two MySQL); its query-preservation regression test disproves the query-loss claim. Run #5e217e: 03306ebaf0 centralizes the TLS mode constants; e781d327b9 fixes the heading and removes the encryption flag override. TLS strength uses the dedicated query.ssl_mode parameter, independently of the boolean encryption flag; 03306ebaf0 adds assertions that building the URI leaves both parameters unchanged. All pre-commit hooks and 162 Doris/MySQL tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
