aminghadersohi commented on PR #44739: URL: https://github.com/apache/superset/pull/44739#issuecomment-5884341855
Addressed bito's additional suggestion (unsafe regex with nested quantifiers, sortResults.ts line 23 and the similar one on line 58) in 394a03dd28. Both patterns are replaced with hand-split sign/fraction/exponent parsing, so each remaining regex is a single flat run of digits and matching is linear. A new test checks the parsers against the old patterns on all 111,111 strings of up to five tokens (identical results) and runs 200k-character near-miss inputs under a time bound. Also merged master in (cd7c69f6e2). Master now sends chart JSON through `df_to_records`, so decimal quoting is opt-out there: chart records keep `Decimal` numbers (`convert_decimals=False` in `query_context_processor`, with a test), and SQL Lab keeps exact strings. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
