aminghadersohi commented on PR #44739: URL: https://github.com/apache/superset/pull/44739#issuecomment-5903778973
> Code Review Agent Run #f7252e: redundant checked counter, NaN branch untested, flaky wall-clock assertion, spread RangeError risk Addressed in 730a8ed6d3: the counter and the `Date.now()` bound are gone. The test asserts the enumeration has exactly 111,111 entries, and `strings()` pushes per element rather than spreading. On the NaN point: `maxLength` counts tokens, not characters, so `NaN`, `Infinity` and `-Infinity` are each one- or two-token strings. The test now asserts they are in the enumeration, so the `NaN`/`Infinity` branches of `isNumericText` are compared against the reference regex. Master merged in 2412b52d34. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
