codeant-ai-for-open-source[bot] commented on code in PR #44739:
URL: https://github.com/apache/superset/pull/44739#discussion_r4129985988
##########
superset/dataframe.py:
##########
@@ -72,7 +86,9 @@ def df_to_records(dframe: pd.DataFrame) -> list[dict[str,
Any]]:
for record in records:
for key in record:
record[key] = (
- None if _is_na(record[key]) else
_convert_big_integers(record[key])
+ None
+ if _is_na(record[key])
+ else _convert_decimals(_convert_big_integers(record[key]))
)
Review Comment:
✅ **Customized review instruction saved!**
**Instruction:**
> Do not flag Decimal precision-loss issues for executor cache writes;
Flask-Caching backends pickle values and preserve Decimal objects, while SQL
Lab result serialization uses df_to_records.
**Applied to:**
- `superset/sql/execution/executor.py`
---
💡 *To manage or update this instruction, visit: [CodeAnt AI
Settings](https://app.codeant.ai/org/settings/learnings)*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
