bito-code-review[bot] commented on PR #44790:
URL: https://github.com/apache/superset/pull/44790#issuecomment-5889468038
<!-- Bito Reply -->
The flagged issue is correct. Normalizing SQL NULL to the same string as a
literal 'N/A' category causes the legend and color mapping to merge these
distinct categories, leading to incorrect visualization.
To resolve this, you should ensure that SQL NULL values are mapped to a
distinct constant (e.g., `<NULL>`) that does not conflict with user-provided
literal values like 'N/A'. The current PR already implements this change in
`superset-frontend/plugins/plugin-chart-echarts/src/Graph/transformProps.ts` by
using `NULL_STRING` instead of 'N/A'.
```typescript
// superset-frontend/plugins/plugin-chart-echarts/src/Graph/transformProps.ts
if (name == null) {
- return 'N/A';
+ return NULL_STRING;
}
```
There are no other comments on this PR to address.
**superset-frontend/plugins/plugin-chart-echarts/src/Graph/transformProps.ts**
```
if (name == null) {
- return 'N/A';
+ return NULL_STRING;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
