endimonan commented on code in PR #44790:
URL: https://github.com/apache/superset/pull/44790#discussion_r4133223013
##########
superset-frontend/plugins/plugin-chart-echarts/src/Graph/transformProps.ts:
##########
@@ -150,7 +151,7 @@ function getCategoryName(columnName: string, name?:
DataRecordValue) {
return `${columnName}: true`;
}
if (name == null) {
Review Comment:
The review comment is valid: it concerns SQL `NULL` versus the literal
string `"<NULL>"`. The current change maps both to the same category key,
merging their legend entry and color. The `"N/A"` collision is fixed, but the
collision identified in the review remains unresolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
