bito-code-review[bot] commented on PR #44803:
URL: https://github.com/apache/superset/pull/44803#issuecomment-5893803112
<!-- Bito Reply -->
The flagged issue is correct. The `useEffect` hook in `FilterBar/index.tsx`
relies on the `filters` object, but it is missing from the dependency array,
which can lead to stale state when configuration changes occur. To resolve
this, add `filters` to the dependency array of the `useEffect` hook.
**superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx**
```
useEffect(() => {
// ... existing logic
}, [filters, ...otherDependencies]);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
