codeant-ai-for-open-source[bot] commented on code in PR #44803:
URL: https://github.com/apache/superset/pull/44803#discussion_r4135546202
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx:
##########
@@ -391,11 +391,11 @@ const FilterBar: FC<FiltersBarProps> = ({
}
});
- // Remove stale entries that no longer exist in dataMaskApplied
+ // Remove stale entries that no longer exist in the configured filters
Object.keys(updated).forEach(filterId => {
if (
!isChartCustomization(filterId) &&
- !(filterId in dataMaskApplied)
+ !(filterId in filters)
) {
Review Comment:
**Suggestion:** This effect now reads `filters`, but `filters` is missing
from its dependencies, so configuration-only changes leave stale selected
entries until another state change occurs.
**Assessment:** ๐ `Major` ยท ๐ `Occurrence: Sometimes` ยท ๐ท๏ธ `Stale reference`
[](https://docs.codeant.ai/cli/resolve-pr-comments-skill)
[](https://app.codeant.ai/fix-in-ide?tool=cursor&prompt_id=969d2cb89d2b40009d7afdc4a79d3463&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
[](https://app.codeant.ai/fix-in-ide?tool=vscode-claude&prompt_id=969d2cb89d2b40009d7afdc4a79d3463&service=github&base_url=https%3A%2F%2Fgithub.com&org=apache&repo=apache%2Fsuperset)
<details>
<summary><b>Prompt for AI Agent ๐ค </b></summary>
```mdx
This is a comment left during a code review.
**Path:**
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx
**Line:** 399:399
**Comment:**
*Stale Reference: This effect now reads `filters`, but `filters` is
missing from its dependencies, so configuration-only changes leave stale
selected entries until another state change occurs.
Validate the correctness of the flagged issue. If correct, How can I resolve
this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask
user if the user wants to fix the rest of the comments as well. if said yes,
then fetch all the comments validate the correctness and implement a minimal fix
```
</details>
<a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44803&comment_hash=54f79c0245dbd1c7f32bc3fb9d62c7e15de35fb0a43a0bfe1d63edcf4b65c28e&reaction=like'>๐</a>
| <a
href='https://app.codeant.ai/feedback?pr_url=https%3A%2F%2Fgithub.com%2Fapache%2Fsuperset%2Fpull%2F44803&comment_hash=54f79c0245dbd1c7f32bc3fb9d62c7e15de35fb0a43a0bfe1d63edcf4b65c28e&reaction=dislike'>๐</a>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
