codeant-ai-for-open-source[bot] commented on code in PR #44803:
URL: https://github.com/apache/superset/pull/44803#discussion_r4135869902
##########
superset-frontend/src/dashboard/components/nativeFilters/FilterBar/index.tsx:
##########
@@ -391,11 +391,11 @@ const FilterBar: FC<FiltersBarProps> = ({
}
});
- // Remove stale entries that no longer exist in dataMaskApplied
+ // Remove stale entries that no longer exist in the configured filters
Object.keys(updated).forEach(filterId => {
if (
!isChartCustomization(filterId) &&
- !(filterId in dataMaskApplied)
+ !(filterId in filters)
) {
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `68dc55e`.
Added `filters` to the effect dependency array, ensuring configuration-only
filter changes trigger synchronization and stale entries are removed.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
