aminghadersohi commented on PR #44604:
URL: https://github.com/apache/superset/pull/44604#issuecomment-5903300402
### Acceptance at a50d2b604b44746dbdcea3cf6ae4d2f24a82cc47
**Executable PR/brief criteria: PASS. Overall acceptance remains
incomplete:** the required linked-story criteria could not be read because its
MCP is unavailable in this session, configured-server catalog, and reviewed
catalog. No code changes or pushes.
Real Postgres 17; `SQL_MAX_ROW=10`; persisted local metadata and an Admin
test user. No execution/parser/cursor mocks. Command:
`SUPERSET_CONFIG_PATH=/tmp/r144/accept44604_config.py
PYTHONPATH="$PWD:$PWD/superset-core/src" /tmp/ss-venv/bin/python
/tmp/r144/accept44604.py` → **40 passed** (27 MCP, 13 SQL Lab API).
| Criterion / executed input | Result |
|---|---|
| MCP `Client(mcp).call_tool('execute_sql', {'request': …})`; `SELECT
generate_series(1,20) AS n` with SQL/request limits 5/8, 8/5, 5/5, absent/5,
0/8 | PASS: 5, 5, 5, 5, 0 rows; stricter limits preserved. |
| Omitted request, SQL `LIMIT 15`; OFFSET, CTE/subquery, expression and
FETCH FIRST variants; dry runs | PASS: omitted returns 15 unchanged; OFFSET
values 3–7; inner-limit values 7–3; expression/FETCH return 5; dry runs retain
`LIMIT 5`. |
| Request below/at/above server maximum: 9/10/11 | PASS: SELECT and
unrewritable `INSERT … RETURNING` return 9/10/10. RETURNING reports
`truncated=true`; exactly 10 available reports false. |
| Fetch truncation vs exact cap | PASS: `SHOW ALL`, cap 5 → 5/true; `SHOW
server_version`, cap 1 → 1/false; RETURNING 6 vs 5 available, cap 5 → 5/true vs
5/false. SQL-rewritten SELECT reports false, as documented for fetch
truncation. |
| Multi-statement last-only cap | PASS: SELECT script returns [20,5]; INSERT
RETURNING plus COUNT returns [20,1], count=20, with cap 5. Earlier statement
remains uncapped. |
| Flask client `POST /api/v1/sqllab/execute/`, `queryLimit=9/10/11` | PASS:
HTTP 200; 9/10/10 rows; SQL overfetch limits 10/11/11. At cap 5, 4/5/6
available → 4/5/5 rows, `NOT_LIMITED`/`NOT_LIMITED`/`DROPDOWN`. Smaller/equal
SQL limits, FETCH FIRST, parenthesized limits and multi-statement execution
also pass. SQL Lab retains its separate per-statement behavior. |
Unit command: `pytest -q
tests/unit_tests/{sql,mcp_service/sql_lab,models/core_test.py,connectors/sqla/utils_test.py,db_engine_specs,commands/sql_lab}`
→ **4,288 passed, 7 skipped**. BigQuery memory/EOF/error handling and Drill
EOF/error mapping are **unit-test evidence only**, not live-service validation.
Existing findings rechecked: truncation/docs/schema fixed in f06ce97e7b,
exact-sample detection in 53718267, buffered-row errors/sample-size nit in
a50d2b60; probe-appending suggestion rebutted by 071a1868 tests. Earlier
expression-limit and budget findings remain fixed in cad654d4/e781f0d7. All
review threads already resolved; no reviewer requests changed.
`pre-commit run --files <all PR-changed paths>` → **12 hooks passed**.
Working tree clean. Postgres container stopped/removed and its created volume
verified removed. Remaining item: linked-story criteria verification.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
