aminghadersohi commented on PR #44604: URL: https://github.com/apache/superset/pull/44604#issuecomment-5903308318
Follow-up to the acceptance comment above: I checked the tracked acceptance criteria against that evidence. - SQL limit smaller than the request, larger than it, or equal: PASS (5/8, 8/5, 5/5 rows above). - Request limit omitted keeps the SQL limit; SQL without a limit gets the cap: PASS. - LIMIT 0, OFFSET, nested/CTE limits left alone: PASS. - Authorization and size guards unchanged; no regex rewriting: PASS. The diff touches no permission code, limits go through the sqlglot parser, and SQL_MAX_ROW still caps the result (9/10/11 → 9/10/10). - Schema description and regression tests updated: PASS. - Repro on a staging examples database: pending until this is deployed. It is read-only and will be recorded then. Acceptance is complete for this head (a50d2b60) apart from that post-deploy check. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
