aminghadersohi commented on PR #44604: URL: https://github.com/apache/superset/pull/44604#issuecomment-5902702087
Full-diff review completed at **a50d2b604b44746dbdcea3cf6ae4d2f24a82cc47**. - **Fixed (P2):** BigQuery's EOF-probe error could trigger fallback after consuming the sample, silently returning only the remaining rows as success. Commit **a50d2b604b** propagates errors after a successful read while preserving initial-fetch fallback. Six regression cases failed before the fix and pass afterward; documentation updated. - **Gabriel's Sept 29 review:** all three asks verified closed: truncation signaling through sync/async/cache/MCP responses, SQL Lab release notes, and last-statement schema wording. - **Bito's Sept 30 review:** appending the probe remains correctly rejected—it exceeds the cap; existing consuming-cursor tests verify explicit truncation. The sample-size test suggestion is addressed in the new commit using the engine constant. - No other correctness, regression, or security findings; no outstanding review asks. Validation: affected SQL, MCP SQL Lab, model, connector, engine-spec, and SQL Lab command suites: **4,288 passed, 7 skipped**. All **12 applicable pre-commit hooks passed**, including mypy, across all PR-changed files. No live BigQuery/SQL Server validation; no services or containers started. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
