EnxDev commented on code in PR #43232:
URL: https://github.com/apache/superset/pull/43232#discussion_r4149483595
##########
superset/commands/chart/importers/v1/__init__.py:
##########
@@ -93,11 +111,19 @@ def _import(
# differs, and keying on that would strand those charts.
datasets[str(config["uuid"])] = dataset
+ # import annotation layers before charts so UUID→ID maps are ready
+ annotation_layer_ids: dict[str, int] = {}
+ for file_name, config in configs.items():
+ if file_name.startswith("annotation_layers/"):
+ layer = import_annotation_layer(config, overwrite=overwrite)
Review Comment:
Good catch. 90d7ba9 adds Gamma tests that go through `ImportChartsCommand`
and `ImportDashboardsCommand` (with `overwrite_all`) against an existing layer,
and check its name, description and annotations afterwards. I checked that
adding `ignore_permissions=True` at either call site now fails them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
