aminghadersohi commented on code in PR #43232:
URL: https://github.com/apache/superset/pull/43232#discussion_r4146076583
##########
superset/commands/chart/importers/v1/__init__.py:
##########
@@ -93,11 +111,19 @@ def _import(
# differs, and keying on that would strand those charts.
datasets[str(config["uuid"])] = dataset
+ # import annotation layers before charts so UUID→ID maps are ready
+ annotation_layer_ids: dict[str, int] = {}
+ for file_name, config in configs.items():
+ if file_name.startswith("annotation_layers/"):
+ layer = import_annotation_layer(config, overwrite=overwrite)
Review Comment:
The Gamma tests reach this gate only through
`ImportAnnotationLayersCommand`, which has no production caller. Adding
`ignore_permissions=True` here (or at dashboard `__init__.py:200`) leaves the
suites green while a Gamma `overwrite=true` chart import renames the layer and
deletes its annotations.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
