codeant-ai-for-open-source[bot] commented on code in PR #43232:
URL: https://github.com/apache/superset/pull/43232#discussion_r4142889021
##########
superset/commands/dashboard/importers/v1/__init__.py:
##########
@@ -164,13 +172,21 @@ def _import(
"datasource_name": dataset.table_name,
}
+ # import annotation layers before charts so UUID→ID maps are ready
+ annotation_layer_ids: dict[str, int] = {}
+ for file_name, config in configs.items():
+ if file_name.startswith("annotation_layers/"):
+ layer = import_annotation_layer(config, overwrite=False)
+ annotation_layer_ids[str(layer.uuid)] = layer.id
Review Comment:
✅ **CodeAnt verified this suggestion was addressed in subsequent commits and
marked this thread resolved** as of `b24c1be`.
Dashboard annotation-layer imports now pass `overwrite=overwrite_assets`,
matching the overwrite behavior used for related databases, datasets, and
charts.
<sub>If that's not right, unresolve this thread and CodeAnt will leave it
open.</sub>
<!-- codeant-auto-resolve-reply -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
