nicob3y commented on code in PR #40919:
URL: https://github.com/apache/superset/pull/40919#discussion_r4158179460


##########
superset-frontend/plugins/plugin-chart-echarts/src/constants.ts:
##########
@@ -27,8 +27,12 @@ import {
   TitleFormData,
 } from './types';
 
-// eslint-disable-next-line import/prefer-default-export
-export const NULL_STRING = '<NULL>';
+// ATTENTION: If you change any constants, make sure to also change 
constants.py

Review Comment:
   I have moved the comment so it is now scoped correctly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to