nicob3y commented on code in PR #40919:
URL: https://github.com/apache/superset/pull/40919#discussion_r4158227811
##########
superset/constants.py:
##########
@@ -15,17 +15,20 @@
# specific language governing permissions and limitations
# under the License.
-# ATTENTION: If you change any constants, make sure to also change
utils/common.js
+# ATTENTION: If you change any constants, make sure to also change
+# plugins/plugin-chart-echarts/src/constants.ts
# string to use when None values *need* to be converted to/from strings
from enum import Enum
+from flask_babel import gettext as __
+
from superset.utils.backports import StrEnum
DEFAULT_USER_AGENT = "Apache Superset"
-NULL_STRING = "<NULL>"
-EMPTY_STRING = "<empty string>"
+NULL_STRING = __("<NULL>")
+EMPTY_STRING = __("<empty string>")
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
