bito-code-review[bot] commented on code in PR #40919:
URL: https://github.com/apache/superset/pull/40919#discussion_r4158181729
##########
superset-frontend/plugins/plugin-chart-echarts/src/constants.ts:
##########
@@ -27,8 +27,12 @@ import {
TitleFormData,
} from './types';
-// eslint-disable-next-line import/prefer-default-export
-export const NULL_STRING = '<NULL>';
+// ATTENTION: If you change any constants, make sure to also change
constants.py
Review Comment:
<!-- Bito Reply -->
The suggestion provided by the reviewer is intended to ensure consistency
between the frontend constants and the corresponding Python constants. If the
new constants are not required in the Python codebase, updating the comment to
specifically reference the constants that do have counterparts is an
appropriate way to address the concern.
**superset-frontend/plugins/plugin-chart-echarts/src/constants.ts**
```
// ATTENTION: If you change NULL_STRING or EMPTY_STRING, make sure to also
change constants.py
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
