aminghadersohi commented on code in PR #44681:
URL: https://github.com/apache/superset/pull/44681#discussion_r4162018235
##########
superset/mcp_service/dashboard/schemas.py:
##########
@@ -417,7 +421,16 @@ class DashboardChartSummary(BaseModel):
id: int | None = Field(None, description="Chart ID")
slice_name: str | None = Field(None, description="Chart name")
viz_type: str | None = Field(None, description="Visualization type")
- datasource_name: str | None = Field(None, description="Datasource name")
+ datasource_id: int | None = Field(
Review Comment:
Fixed in 3ec0c45ec19e40f26e43964b42326898ebdfafb7. DashboardChartSummary
includes datasource_type alongside datasource_id through the shared serializer
used by dashboard info and generate/add/remove/duplicate responses. Both fields
use the same data-model metadata gate. Regression tests cover table and
semantic-view charts sharing an ID, query/saved-query types, and
restricted/default redaction; documentation is updated. Validation: 734 unit
tests passed, a final 42-test live-datasource rerun passed, and pre-commit
passed (including mypy).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
