etr2460 commented on a change in pull request #8743: Fix a bunch of files with pylint disabled URL: https://github.com/apache/incubator-superset/pull/8743#discussion_r353481232
########## File path: superset/jinja_context.py ########## @@ -273,5 +272,5 @@ class HiveTemplateProcessor(PrestoTemplateProcessor): def get_template_processor(database, table=None, query=None, **kwargs): - TP = template_processors.get(database.backend, BaseTemplateProcessor) - return TP(database=database, table=table, query=query, **kwargs) + tp = template_processors.get(database.backend, BaseTemplateProcessor) Review comment: why not name `template_processor`? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
