etr2460 commented on a change in pull request #8743: Fix a bunch of files with
pylint disabled
URL:
https://github.com/apache/incubator-superset/pull/8743#discussion_r353481546
##########
File path: superset/sql_lab.py
##########
@@ -175,12 +173,11 @@ def get_sql_results(
def execute_sql_statement(sql_statement, query, user_name, session, cursor):
"""Executes a single SQL statement"""
- query_id = query.id
database = query.database
db_engine_spec = database.db_engine_spec
parsed_query = ParsedQuery(sql_statement)
sql = parsed_query.stripped()
- SQL_MAX_ROWS = app.config["SQL_MAX_ROW"]
+ sql_max_rows = app.config["SQL_MAX_ROW"]
Review comment:
should this be pulled out of the function to the top of the file? Then we
keep the same var name but don't need to refetch from the app config each time
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
