etr2460 commented on a change in pull request #8743: Fix a bunch of files with pylint disabled URL: https://github.com/apache/incubator-superset/pull/8743#discussion_r356289754
########## File path: superset/sql_lab.py ########## @@ -14,14 +14,16 @@ # KIND, either express or implied. See the License for the # specific language governing permissions and limitations # under the License. -# pylint: disable=C,R,W import logging import uuid from contextlib import closing from datetime import datetime from sys import getsizeof from typing import Optional, Tuple, Union +# pylint and isort disagree on the correct import order. +# Let's have isort win. +# pylint: disable=ungrouped-imports Review comment: should we add this to a base pylint rule disable? so that we don't need it on a bunch of files? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
