aminghadersohi commented on PR #43770: URL: https://github.com/apache/superset/pull/43770#issuecomment-5963211674
@rusackas quick clarification on the Gantt `allows_empty_result` note: the flag is on master now (it came in with #44746), and this branch no longer changes gantt.py's `allows_empty_result` relative to master, so there is no longer a Gantt behavior difference in this PR. The saved-chart plugin-contract scope for update_chart / update_chart_preview is in place and covered by the disabled-Treemap tests. Head 88d884fbe0 has all checks green, no unresolved threads, and a clean merge with master. Re-requested your review earlier; happy to adjust anything else. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
