aminghadersohi commented on PR #44148: URL: https://github.com/apache/superset/pull/44148#issuecomment-5967222146
Two review-body notes left as is: `linear_color_scheme` stays free text because the scheme names come from an extensible registry (including custom schemes), not a fixed set the plugin enumerates, and `number_format` is a free-form d3 format string, so a `Literal` would reject valid values. The country-map `sourceValues` lookup is already guarded by `hasOwnProperty`, so prototype keys cannot be injected. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
